feat(documents): prepare inbox suggestions and add entity assignments

backend/tests/scannerInbox.test.ts

@@ -193,10 +193,14 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
         CREATE TABLE filetags (id uuid PRIMARY KEY, tenant bigint, name text, archived boolean DEFAULT false);
         CREATE TABLE folders (id uuid PRIMARY KEY, tenant bigint, name text, parent uuid, "standardFiletype" uuid,
             "standardFiletypeIsOptional" boolean DEFAULT true, archived boolean DEFAULT false);
-        CREATE TABLE auth_profiles (tenant_id bigint, user_id uuid, customer_for_portal bigint);`)
+        CREATE TABLE projects (id bigint PRIMARY KEY, tenant bigint, name text, archived boolean DEFAULT false);
+        CREATE TABLE customers (id bigint PRIMARY KEY, tenant bigint, name text, archived boolean DEFAULT false);
+        CREATE TABLE checks (id uuid PRIMARY KEY, tenant bigint, name text, archived boolean DEFAULT false);
+        CREATE TABLE auth_profiles (id uuid DEFAULT gen_random_uuid(), tenant_id bigint, user_id uuid, customer_for_portal bigint,
+            full_name text, active boolean DEFAULT true);`)
     const migrationRoot = path.resolve(__dirname, "../db/migrations")
     const journal = JSON.parse(await readFile(path.join(migrationRoot, "meta/_journal.json"), "utf8"))
-    const entries = ["0073_scanner_document_inbox", "0074_scanner_inbox_filing"].map(tag => journal.entries.find((item: any) => item.tag === tag))
+    const entries = ["0073_scanner_document_inbox", "0074_scanner_inbox_filing", "0077_scanner_inbox_preparation"].map(tag => journal.entries.find((item: any) => item.tag === tag))
     await mkdir(path.join(tempMigrations, "meta"))
     for (const entry of entries) {
         assert.ok(entry)
@@ -213,14 +217,17 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
     const analyses: any[] = []
     let analysisGate: Promise<void> | undefined
     let analysisStarted: (() => void) | undefined
+    let analysisFailure = false
     const service = createScannerInboxService(db, {
         async put(key, body) { stored.set(key, Buffer.from(body)); if (storageFailure) throw new Error("Simulated object store failure") },
         async remove(key) { stored.delete(key) },
     }, async (document, candidates) => {
         analyses.push({ document, candidates })
+        const result = aiResult
         analysisStarted?.()
         await analysisGate
-        return aiResult
+        if (analysisFailure) throw new Error("Simulated AI failure")
+        return result
     })
     const first = await service.credentials(1)
     const second = await service.credentials(2)
@@ -265,6 +272,8 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
         assert.equal(row.tenant, "1")
         assert.equal(row.mimeType, "application/pdf")
         assert.equal(row.extracted_text, null)
+        assert.equal((await pool.query("SELECT suggestion_status FROM scanner_inbox_documents WHERE file_id=$1", [row.id])).rows[0].suggestion_status, "pending")
+        assert.equal(analyses.length, 0, "the upload only queues preparation; it does not wait for OCR/AI")
         assert.deepEqual(stored.get(row.path), pdf)
         assert.equal((await PDFDocument.load(stored.get(row.path)!)).getPageCount(), 2)
         const listing = await app.inject({ method: "GET", url: "/api/document-inbox" })
@@ -332,17 +341,21 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
         [targetFolder, targetType, foreignFolder, archivedFolder])
     const fileInto = (id: string, folder: string | null = targetFolder, type: string = targetType, headers = {}) =>
         app.inject({ method: "POST", url: `/api/document-inbox/${id}/file`, payload: { folder, type }, headers })
-    const suggest = (id: string, headers = {}) => app.inject({ method: "POST", url: `/api/document-inbox/${id}/suggestion`, headers })
+    const suggest = (id: string, headers = {}) => app.inject({ method: "GET", url: `/api/document-inbox/${id}/suggestion`, headers })
+    const queue = (id: string, headers = {}) => app.inject({ method: "POST", url: `/api/document-inbox/${id}/suggestion`, headers })
     await t.test("AI analysis is tenant scoped, validates destinations and never files a document", async () => {
         const id = (await service.list(1, 50, 0, "scan.pdf")).documents[0].id
         const before = (await pool.query("SELECT folder, type, extracted_text FROM files WHERE id=$1", [id])).rows[0]
         aiResult = { suggestion: { folderId: targetFolder, typeId: targetType, confidence: "high", reason: "Rechnung erkannt." } }
         assert.equal((await suggest(id, { "x-test-tenant": "2" })).statusCode, 404)
         assert.equal((await suggest("invalid")).statusCode, 400)
-        await pool.query("INSERT INTO auth_profiles VALUES (1, $1, 123)", [userId])
+        await pool.query("INSERT INTO auth_profiles (tenant_id, user_id, customer_for_portal) VALUES (1, $1, 123)", [userId])
         assert.equal((await suggest(id)).statusCode, 403)
         await pool.query("DELETE FROM auth_profiles")
         assert.equal(analyses.length, 0)
+        assert.equal((await suggest(id)).json().status, "pending")
+        assert.equal(analyses.length, 0, "reading the preview never starts analysis")
+        assert.equal(await service.processNextSuggestion(), true)
         const result = await suggest(id, { "x-test-admin": "false" })
         assert.equal(result.statusCode, 200, result.body)
         assert.deepEqual(result.json().suggestion, aiResult.suggestion)
@@ -352,6 +365,8 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
         assert.deepEqual((await pool.query("SELECT folder, type, extracted_text FROM files WHERE id=$1", [id])).rows[0], before)
         assert.equal((await service.list(1, 50, 0, "scan.pdf")).total, 1)
         aiResult = { suggestion: { ...aiResult.suggestion!, folderId: foreignFolder } }
+        assert.equal((await queue(id)).statusCode, 202)
+        await service.processNextSuggestion()
         assert.equal((await suggest(id)).json().suggestion, null)
     })
     await t.test("AI results are checked again if destination availability changes during analysis", async () => {
@@ -360,15 +375,93 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
         let finish!: () => void
         analysisGate = new Promise(resolve => { finish = resolve })
         const started = new Promise<void>(resolve => { analysisStarted = resolve })
-        const pending = suggest(id).then(response => response)
+        await queue(id)
+        const pending = service.processNextSuggestion()
         await started
         await pool.query("UPDATE folders SET archived=true WHERE id=$1", [targetFolder])
         finish()
-        assert.equal((await pending).json().suggestion, null)
+        await pending
+        assert.equal((await suggest(id)).json().suggestion, null)
         await pool.query("UPDATE folders SET archived=false WHERE id=$1", [targetFolder])
         analysisGate = undefined
         analysisStarted = undefined
     })
+    await t.test("prepared results persist, failed jobs wait for explicit retry and expired claims resume", async () => {
+        const id = (await service.list(1, 50, 0, "scan.pdf")).documents[0].id
+        const otherService = createScannerInboxService(db, undefined, async () => aiResult)
+        const before = analyses.length
+        assert.equal((await otherService.getSuggestion(1, id)).status, "ready")
+        assert.equal(analyses.length, before)
+        await queue(id)
+        analysisFailure = true
+        await service.processNextSuggestion()
+        analysisFailure = false
+        assert.equal((await suggest(id)).json().status, "failed")
+        assert.equal((await suggest(id)).json().suggestion, null)
+        const failedCount = analyses.length
+        await suggest(id)
+        assert.equal(analyses.length, failedCount)
+        await queue(id)
+        await pool.query("UPDATE scanner_inbox_documents SET suggestion_status='processing', suggestion_claim=$2, suggestion_updated_at=now()-interval '6 minutes' WHERE file_id=$1", [id, randomUUID()])
+        aiResult = { suggestion: { folderId: targetFolder, typeId: targetType, confidence: "high", reason: "Vorbereitet nach Neustart." } }
+        await otherService.processNextSuggestion()
+        assert.equal((await suggest(id)).json().suggestion.reason, "Vorbereitet nach Neustart.")
+    })
+    await t.test("an expired worker cannot overwrite a newer completed suggestion", async () => {
+        const id = (await service.list(1, 50, 0, "scan.pdf")).documents[0].id
+        await queue(id)
+        aiResult = { suggestion: { folderId: targetFolder, typeId: targetType, confidence: "high", reason: "Alter Vorschlag." } }
+        let finish!: () => void
+        analysisGate = new Promise(resolve => { finish = resolve })
+        const started = new Promise<void>(resolve => { analysisStarted = resolve })
+        const pending = service.processNextSuggestion()
+        await started
+        await pool.query("UPDATE scanner_inbox_documents SET suggestion_updated_at=now()-interval '6 minutes' WHERE file_id=$1", [id])
+        const otherService = createScannerInboxService(db, undefined, async () => ({ suggestion: {
+            folderId: null, typeId: alternativeType, confidence: "medium", reason: "Neuer Vorschlag.",
+        } }))
+        await otherService.processNextSuggestion()
+        finish()
+        await pending
+        assert.equal((await suggest(id)).json().suggestion.reason, "Neuer Vorschlag.")
+        analysisGate = undefined
+        analysisStarted = undefined
+    })
+    await t.test("entity choices and filing reject foreign, archived and wrong-type IDs atomically", async () => {
+        await pool.query("INSERT INTO projects VALUES (11, 1, 'Umbau', false), (12, 2, 'Fremdes Projekt', false), (13, 1, 'Archiv', true)")
+        await pool.query("INSERT INTO customers VALUES (21, 1, 'Musterkunde', false), (22, 2, 'Fremder Kunde', false)")
+        const checkId = randomUUID()
+        const profileId = randomUUID()
+        await pool.query("INSERT INTO checks VALUES ($1, 1, 'Prüfung', false)", [checkId])
+        await pool.query("INSERT INTO auth_profiles (id, tenant_id, full_name) VALUES ($1, 1, 'Test Mitarbeiter')", [profileId])
+        const choices = await app.inject({ method: "GET", url: "/api/document-inbox/assignment-options?kind=project&search=Umbau" })
+        assert.deepEqual(choices.json(), [{ id: "11", name: "Umbau" }])
+        assert.equal((await app.inject({ method: "GET", url: "/api/document-inbox/assignment-options?kind=unknown" })).statusCode, 400)
+        const id = (await service.list(1, 50, 0, "scan.pdf")).documents[0].id
+        for (const assignments of [{ project: "12" }, { project: "13" }, { project: randomUUID() }, { project: "11", customer: "22" }, { check: 11 }, { authProfile: randomUUID() }]) {
+            const res = await app.inject({ method: "POST", url: `/api/document-inbox/${id}/file`, payload: { folder: targetFolder, type: targetType, assignments } })
+            assert.equal(res.statusCode, 400, res.body)
+        }
+        assert.deepEqual((await pool.query("SELECT folder, type, project, customer FROM files WHERE id=$1", [id])).rows[0], { folder: null, type: null, project: null, customer: null })
+        await pool.query("UPDATE files SET project=11 WHERE id=$1", [id])
+        assert.deepEqual((await app.inject({ method: "GET", url: `/api/document-inbox/${id}/assignments` })).json(), [{ kind: "project", id: "11", name: "Umbau", available: true }])
+        assert.equal((await app.inject({ method: "GET", url: `/api/document-inbox/${id}/assignments`, headers: { "x-test-tenant": "2" } })).statusCode, 404)
+        await service.fileDocument(1, userId, id, targetFolder, targetType, { project: null, customer: "21", check: checkId, authProfile: profileId })
+        assert.deepEqual((await pool.query('SELECT project, customer, "check", auth_profile FROM files WHERE id=$1', [id])).rows[0], { project: null, customer: '21', check: checkId, auth_profile: profileId })
+        // Restore the fixture so existing retry/filing tests can exercise this same original document.
+        await pool.query('UPDATE files SET folder=null, type=null, customer=null, "check"=null, auth_profile=null WHERE id=$1', [id])
+        await pool.query("UPDATE scanner_inbox_documents SET filed_at=null WHERE file_id=$1", [id])
+    })
+    await t.test("menu count includes only this tenant's open, unarchived documents", async () => {
+        const res = await app.inject({ method: "GET", url: "/api/document-inbox/count" })
+        assert.equal(res.json().total, (await service.list(1, 50, 0, "")).total)
+        const other = await app.inject({ method: "GET", url: "/api/document-inbox/count", headers: { "x-test-tenant": "2" } })
+        assert.equal(other.json().total, 1)
+        const id = (await service.list(1, 50, 0, "failed.pdf")).documents[0].id
+        await pool.query("UPDATE files SET archived=true WHERE id=$1", [id])
+        assert.equal((await service.openCount(1)).total, res.json().total - 1)
+        await pool.query("UPDATE files SET archived=false WHERE id=$1", [id])
+    })
     await t.test("filing options and destinations exclude other tenants and archived entries", async () => {
         const options = await app.inject({ method: "GET", url: "/api/document-inbox/filing-options" })
         assert.equal(options.statusCode, 200)
@@ -388,7 +481,7 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
         await pool.query("UPDATE tenants SET locked='maintenance_tenant' WHERE id=1")
         assert.equal((await fileInto(id)).statusCode, 423)
         await pool.query("UPDATE tenants SET locked=null WHERE id=1")
-        await pool.query("INSERT INTO auth_profiles VALUES (1, $1, 123)", [userId])
+        await pool.query("INSERT INTO auth_profiles (tenant_id, user_id, customer_for_portal) VALUES (1, $1, 123)", [userId])
         assert.equal((await fileInto(id)).statusCode, 403)
         assert.equal((await app.inject({ method: "GET", url: "/api/document-inbox/filing-options" })).statusCode, 403)
         await pool.query("DELETE FROM auth_profiles")
@@ -444,7 +537,7 @@ test("scanner inbox integration: migration, persistence, isolation, retries and
             assert.equal((await app.inject({ method, url, headers: { "x-test-admin": "false" } })).statusCode, 403)
         }
         assert.equal((await app.inject({ method: "GET", url: "/api/document-inbox", headers: { "x-test-admin": "false" } })).statusCode, 200)
-        await pool.query("INSERT INTO auth_profiles VALUES (1, $1, 123)", [userId])
+        await pool.query("INSERT INTO auth_profiles (tenant_id, user_id, customer_for_portal) VALUES (1, $1, 123)", [userId])
         assert.equal((await app.inject({ method: "GET", url: "/api/document-inbox" })).statusCode, 403)
         await pool.query("DELETE FROM auth_profiles")
     })